New Patch (4914) for Google Voice Call
New Patch (4914) for Google Voice Call
The existing patch 4691 has couple of issues related to matching the callback and the inconsistency in the GoogleVoiceCall method in the patch with the SipSorcery server.
I have fixed these issues in a new patch (patch 4914). You can find out more information on the new patch here.
I have fixed these issues in a new patch (patch 4914). You can find out more information on the new patch here.
I have compared the files for Patch 4914 and changed set 27686. There is no change required for GoogleVoiceCall.cs, but DialPlanScriptHelper.cs requires some merge. Please get the merged DialPlanScriptHelper.cs file from here which shall be compatible with change set 27686.
I am assuming that you have a Visual Studio Environment setup for change set 27868. Let me know how you get on.
I am assuming that you have a Visual Studio Environment setup for change set 27868. Let me know how you get on.
It doesn't seem to work missing an argument
If I remove the Phone type it starts google voice but the rnr_se key could not be found
Code: Select all
DialPlan 13:37:30:628: Using dialplan google for Out call to sip:8008351007@sip.huizenwireless.nl.
NewCall 13:37:31:089: Executing script dial plan for call to sip:8008351007@sip.huizenwireless.nl.
DialPlan 13:37:31:910: There was an exception executing your dial plan script: wrong number of arguments (6 for 5)
DialPlan 13:37:32:070: Dial plan execution completed without answering and had an execution error message of Dial plan exception.
Code: Select all
DialPlan 13:44:03:663: UAS call progressing with Ringing.
DialPlan 13:44:03:673: Logging into google.com for jvwelzen@huizenwireless.nl.
DialPlan 13:44:05:125: Google Voice home page loaded successfully.
DialPlan 13:44:05:145: Exception on GoogleVoiceCall. Could not find _rnr_se key on your Google Voice account page, callback cannot proceed.
DialPlan 13:44:05:566: Dial plan execution completed without answering and with no last failure status.
Looks like you have a different signature for the GoogleVoiveCall Method. Can you check if to have got following methods in DialPlanScriptHelper.cs
- /public void GoogleVoiceCall(string emailAddress, string password, string forwardingNumber, string destinationNumber, bool notUsed)
//{
// GoogleVoiceCall(emailAddress, password, forwardingNumber, destinationNumber, null, DEFAULT_GOOGLEVOICE_PHONETYPE, 0);
//}
public void GoogleVoiceCall(string emailAddress, string password, string forwardingNumber, string destinationNumber)
{
GoogleVoiceCall(emailAddress, password, forwardingNumber, destinationNumber, null, DEFAULT_GOOGLEVOICE_PHONETYPE, 0);
}
public void GoogleVoiceCall(string emailAddress, string password, string forwardingNumber, string destinationNumber, string fromURIUserToMatch)
{
GoogleVoiceCall(emailAddress, password, forwardingNumber, destinationNumber, fromURIUserToMatch, DEFAULT_GOOGLEVOICE_PHONETYPE, 0);
}
public void GoogleVoiceCall(string emailAddress, string password, string forwardingNumber, string destinationNumber, string fromURIUserToMatch, int phoneType)
{
GoogleVoiceCall(emailAddress, password, forwardingNumber, destinationNumber, fromURIUserToMatch, phoneType, 0);
}
public void GoogleVoiceCall(string emailAddress, string password, string forwardingNumber, string destinationNumber, string fromURIUserToMatch, int phoneType, int waitForCallbackTimeout)
{
I have got the same in DialPlanScriptHelper.cs
Code: Select all
//public void GoogleVoiceCall(string emailAddress, string password, string forwardingNumber, string destinationNumber, bool notUsed)
//{
// GoogleVoiceCall(emailAddress, password, forwardingNumber, destinationNumber, null, DEFAULT_GOOGLEVOICE_PHONETYPE, 0);
//}
public void GoogleVoiceCall(string emailAddress, string password, string forwardingNumber, string destinationNumber)
{
GoogleVoiceCall(emailAddress, password, forwardingNumber, destinationNumber, null, DEFAULT_GOOGLEVOICE_PHONETYPE, 0);
}
public void GoogleVoiceCall(string emailAddress, string password, string forwardingNumber, string destinationNumber, string fromURIUserToMatch)
{
GoogleVoiceCall(emailAddress, password, forwardingNumber, destinationNumber, fromURIUserToMatch, DEFAULT_GOOGLEVOICE_PHONETYPE, 0);
}
public void GoogleVoiceCall(string emailAddress, string password, string forwardingNumber, string destinationNumber, string fromURIUserToMatch, int phoneType)
{
GoogleVoiceCall(emailAddress, password, forwardingNumber, destinationNumber, fromURIUserToMatch, phoneType, 0);
}
public void GoogleVoiceCall(string emailAddress, string password, string forwardingNumber, string destinationNumber, string fromURIUserToMatch, int phoneType, int waitForCallbackTimeout)
{
try